[
https://issues.apache.org/jira/browse/PLC4X-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123494#comment-17123494
]
Alessandro Rossignoli commented on PLC4X-201:
---------------------------------------------
Personally I would go with the second, but I agree with you it's a bit
aggressive and as I have tested the implementation the generic type spreads
almost everywhere, so it has to be taken very consciously. We are actually
using the first modification on the field for testing purposes so it looks good
enough for now.
I would like to do a PR for this and for issue #200, but I am worried to get
something wrong on naming of the branches/conventions/building.
To build the project I also had to disable some maven plugins
(check-dependencies) as there were some libraries removed from maven central
that some dependencies are using.
Can someone of you guys support me on this eventually?
> OPC-UA PlcList underlying type not compatible with Eclipse Milo
> ---------------------------------------------------------------
>
> Key: PLC4X-201
> URL: https://issues.apache.org/jira/browse/PLC4X-201
> Project: Apache PLC4X
> Issue Type: Bug
> Components: Driver-OPC-UA
> Affects Versions: 0.7.0
> Reporter: Alessandro Rossignoli
> Priority: Major
> Labels: beginner
>
> java.util.Collections$UnmodifiableRandomAccessList is not compatible with
> Eclipse Milo built-in types.
> When writing to the OPC-UA driver a simple array of Double, I receive the
> following error:
> [org.eclipse.milo.opcua.stack.core.serialization.OpcUaBinaryStreamEncoder:608]:
> Not a built-in type: class java.util.Collections$UnmodifiableRandomAccessList
> When writing a single value in the array the type is PlcDouble instead of
> PlcList, and there is no error.
>
> I think that a possible solution could be changing the underlying type, or
> better to change the getter for the value.
> [https://github.com/apache/plc4x/blob/4a74ff526aeb57e978005e37c878fe55021462aa/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcList.java#L46]
> I will try to find myself a solution and I will keep you posted.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
