[ 
https://issues.apache.org/jira/browse/PLC4X-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218971#comment-17218971
 ] 

Christofer Dutz commented on PLC4X-252:
---------------------------------------

How would you avoid passing in a Modbus field to a S7 connection in this case?

> Provide read and write builder method variants with supplied PlcField
> ---------------------------------------------------------------------
>
>                 Key: PLC4X-252
>                 URL: https://issues.apache.org/jira/browse/PLC4X-252
>             Project: Apache PLC4X
>          Issue Type: Improvement
>          Components: API
>    Affects Versions: 0.8.0
>            Reporter: Ɓukasz Dywicki
>            Priority: Major
>             Fix For: 0.8.0
>
>
> At the present each operation involving driver requires construction of a 
> field "query string". While it permits implementers rely on generic field 
> syntax it also has downsides - it won't capture changes in how fields are 
> constructed.
> For that reason we would like to introduce a second option for specifying 
> field queries which would permit passing of `PlcField` instances directly.
> {code:lang=java|title=PlcWriteRequest.Builder.java}
>     PlcWriteRequest.Builder addItem(String name, String fieldQuery, 
> Boolean... values);
> {code}
> would receive second option
> {code:lang=java|title=PlcWriteRequest.Builder.java}
>     PlcWriteRequest.Builder addItem(String name, PlcField fieldQuery, 
> Boolean... values);
> {code}
> for all possible combinations of write calls.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to