[ 
https://issues.apache.org/jira/browse/PLC4X-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488472#comment-17488472
 ] 

César García commented on PLC4X-331:
------------------------------------

Hola,

This modification solves the points indicated.

And of course you should call "shutdown()" when closing the driver. The VM 
should take care of this, but this is best practice.


[https://github.com/glcj/plc4x/blob/PLC4X-331/plc4j/spi/src/main/java/org/apache/plc4x/java/spi/transaction/RequestTransactionManager.java]

 

Kind regards,

> The transaction manager executor does not allow closing connections to 
> devices.
> -------------------------------------------------------------------------------
>
>                 Key: PLC4X-331
>                 URL: https://issues.apache.org/jira/browse/PLC4X-331
>             Project: Apache PLC4X
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.9.0
>            Reporter: César García
>            Assignee: César García
>            Priority: Major
>             Fix For: 0.9.0
>
>
>  
>  # Identification of the executor and do not use the generic name. 
>  #  Add a "shutdown" method to terminate the task executor in a controlled 
> manner. 
>  #  Remove the "static" property from the executor, so it can be used in a 
> dynamic environment. 
>  #  Modify the use of logging in derived tasks.
>  # A general rule must be followed that all drivers must call the new 
> transaction handler "shutdown" method in their respective "close" method.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to