splatch commented on issue #1897: URL: https://github.com/apache/plc4x/issues/1897#issuecomment-2480666481
Hello @hyslopc, Thank you for report, you are right that we have maybe not conflicting, but somewhat overlapping logic. This comes from fact that the difference between connected server and advertised hostname in its endpoints, which you mentioned, is indeed quite common. The `endpoint-host` and `endpoint-port` parameters are recent inventions in 0.13 which allowed us to have a dynamic port/host pairs within unit tests, but as you found, can address also above problem. I have not removed earlier logic (attempting to resolve ip from host etc.) simply to avoid behavior change. @hutcheb Are you ok to remove host resolution attempts in favor of fixing endpoint URI through two parameters mentioned here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
