chrisdutz commented on issue #1974:
URL: https://github.com/apache/plc4x/issues/1974#issuecomment-2590193143
Ok ... I had a look and there were several issues:
1. You name the protocol "fins" in
protocols/omron/src/main/java/org/apache/plc4x/protocol/omron/FinsProtocol.java
but you try to use it as "omron" in plc4j/drivers/omron/pom.xml ... the two
have to match, I tried setting it to "fins" and it picked up the protocol
definition
2. Your mspec had multiple issues:
- There was an odd prefix to the mspec: "好的，根据你提供的西门子PLC
S7协议的MSpec文件结构，我将为你生成一个详细的Omron
FINS协议的MSpec文件。这个文件将包括FINS协议的基本消息结构、请求和响应消息、以及一些常见的命令和响应。
### Omron FINS协议MSpec文件
```freemarker" ... that needed to be removed.
- You repeatedly defined byte-arrays like this:
[simple byte[] data length 'wordCount * 2']
However this needed to be changed to:
[array byte data length 'wordCount * 2']
(Notice the keyword "array" instead of "simple"? Also the bracets
needed to be removed
- In line 192 (187 after removing the header) you define a string
simple type ... strings need a fixed number of bits ... vstring doesn't, but
that requires an expression on how long the string should be
- Your enum FINSResponseCode had one additional closing square bracket,
that needed to be removed
With these changes I was able to generate the code for your mspec and
compile it.
I did add a config option to skip the maven-dependency-plugin execution as
you're just starting to implement your driver ... no need to get too confused
about that. You can take care of that once you're done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
