MonkeyCanCode commented on code in PR #398:
URL: https://github.com/apache/polaris/pull/398#discussion_r1814165181


##########
site/content/in-dev/unreleased/overview.md:
##########
@@ -180,6 +180,12 @@ To secure interactions with service connections, Polaris 
vends temporary storage
 execution. These credentials allow the query engine to run the query without 
requiring access to your external cloud storage for
 Iceberg tables. This process is called credential vending.
 
+As of now, the following limitations are known regarding Apache Iceberg 
support:
+
+- **remove_orphan_files:** This operation does not currently support 
+  credential vending when utilizing Apache Spark as the compute engine.
+  - For more details, please refer to 
[apache/iceberg#7914](https://github.com/apache/iceberg/pull/7914).

Review Comment:
   From some quick read, Hugo style link is mainly for internal links within 
the site and external links seems to be preferred as markdown's style instead. 
Also, there are many places we are using markdown style links for external 
reference across current site. If that is more preferred, should we do it in a 
different PR instead?
    
   Then in terms of table maintenance operations validation with credential 
vending, following are tested:
   
   Trino:
    - optimize: passed
    - expire_snapshots: passed
    - remove_orphan_files: passed
    - drop_extended_stats: passed
   
   Spark:
   - expire_snapshots: passed
   - remove_orphan_files: failed (not supported as mentioned in this PR)
   - rewrite_data_files: passed
   - rewrite_manifests: passed
   - rewrite_position_delete_files: passed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to