eric-maynard commented on code in PR #396:
URL: https://github.com/apache/polaris/pull/396#discussion_r1817032369
##########
polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizer.java:
##########
@@ -514,12 +517,12 @@ public void authorizeOrThrow(
"Principal '%s' is not authorized for op %s due to
PRINCIPAL_CREDENTIAL_ROTATION_REQUIRED_STATE",
authenticatedPrincipal.getName(), authzOp);
} else if (!isAuthorized(
- authenticatedPrincipal, activatedGranteeIds, authzOp, targets,
secondaries)) {
+ authenticatedPrincipal, activatedEntities, authzOp, targets,
secondaries)) {
throw new ForbiddenException(
- "Principal '%s' with activated PrincipalRoles '%s' and activated ids
'%s' is not authorized for op %s",
+ "Principal '%s' with activated PrincipalRoles '%s' and activated
grants via '%s' is not authorized for op %s",
Review Comment:
I think what this message is trying to say is that you have grants _through_
/ _via_ these roles. So you may have a grant on table X through your principal
role A and catalog role B but you fail when you try to read table Y. This
message will say `...and activated grants via [A, B]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
