danielhumanmod commented on code in PR #312:
URL: https://github.com/apache/polaris/pull/312#discussion_r1828748715
##########
polaris-service/src/test/java/org/apache/polaris/service/task/TableCleanupTaskHandlerTest.java:
##########
@@ -318,21 +351,181 @@ public void testTableCleanupMultipleSnapshots() throws
IOException {
Assertions.assertThatPredicate(handler::canHandleTask).accepts(task);
CallContext.setCurrentContext(CallContext.of(realmContext,
polarisCallContext));
+
handler.handleTask(task);
- assertThat(
- metaStoreManagerFactory
- .getOrCreateMetaStoreManager(realmContext)
- .loadTasks(polarisCallContext, "test", 5)
- .getEntities())
+ List<PolarisBaseEntity> entities =
+ metaStoreManagerFactory
+ .getOrCreateMetaStoreManager(realmContext)
+ .loadTasks(polarisCallContext, "test", 5)
+ .getEntities();
+
+ List<PolarisBaseEntity> manifestCleanupTasks =
+ entities.stream()
+ .filter(
+ entity -> {
+ AsyncTaskType taskType =
TaskEntity.of(entity).getTaskType();
+ return taskType == AsyncTaskType.FILE_CLEANUP;
+ })
+ .toList();
+
+ assertThat(manifestCleanupTasks)
+ // all three manifests should be present, even though one is
excluded from the latest
+ // snapshot
+ .hasSize(4)
+ .satisfiesExactlyInAnyOrder(
+ taskEntity ->
+ assertThat(taskEntity)
+ .returns(PolarisEntityType.TASK.getCode(),
PolarisBaseEntity::getTypeCode)
+ .extracting(TaskEntity::of)
+ .returns(
+ new
ManifestFileCleanupTaskHandler.ManifestCleanupTask(
+ tableIdentifier,
+
Base64.encodeBase64String(ManifestFiles.encode(manifestFile1))),
+ entity ->
+ entity.readData(
+
ManifestFileCleanupTaskHandler.ManifestCleanupTask.class)),
+ taskEntity ->
+ assertThat(taskEntity)
+ .returns(PolarisEntityType.TASK.getCode(),
PolarisBaseEntity::getTypeCode)
+ .extracting(TaskEntity::of)
+ .returns(
+ new
ManifestFileCleanupTaskHandler.ManifestCleanupTask(
+ tableIdentifier,
+
Base64.encodeBase64String(ManifestFiles.encode(manifestFile2))),
+ entity ->
+ entity.readData(
+
ManifestFileCleanupTaskHandler.ManifestCleanupTask.class)),
+ taskEntity ->
+ assertThat(taskEntity)
+ .returns(PolarisEntityType.TASK.getCode(),
PolarisBaseEntity::getTypeCode)
+ .extracting(TaskEntity::of)
+ .returns(
+ new
ManifestFileCleanupTaskHandler.ManifestCleanupTask(
+ tableIdentifier,
+
Base64.encodeBase64String(ManifestFiles.encode(manifestFile3))),
+ entity ->
+ entity.readData(
+
ManifestFileCleanupTaskHandler.ManifestCleanupTask.class)),
+ taskEntity ->
+ assertThat(taskEntity)
+ .returns(PolarisEntityType.TASK.getCode(),
PolarisBaseEntity::getTypeCode)
+ .extracting(TaskEntity::of)
+ .returns(
+ new
ManifestFileCleanupTaskHandler.ManifestCleanupTask(
+ tableIdentifier,
+ List.of(statisticsFile1.path(),
statisticsFile2.path())),
+ entity ->
+ entity.readData(
+
ManifestFileCleanupTaskHandler.ManifestCleanupTask.class)));
+ }
+ }
+
+ @Test
Review Comment:
3. Cleanup of multiple metadata files across multiple snapshots (New)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
