lefebsy commented on code in PR #389:
URL: https://github.com/apache/polaris/pull/389#discussion_r1830227895
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisCredentialProperty.java:
##########
@@ -23,6 +23,8 @@ public enum PolarisCredentialProperty {
AWS_KEY_ID(String.class, "s3.access-key-id", "the aws access key id"),
AWS_SECRET_KEY(String.class, "s3.secret-access-key", "the aws access key
secret"),
AWS_TOKEN(String.class, "s3.session-token", "the aws scoped access token"),
+ AWS_ENDPOINT(String.class, "s3.endpoint", "the aws s3 endpoint"),
+ AWS_PATH_STYLE_ACCESS(Boolean.class, "s3.path-style-access", "the aws s3
path style access"),
Review Comment:
Many S3COMPATIBLE solutions are deployed without network devices or
configurations in front of them allowing support of dynamic hosts names
including buckets.
TLS certificate with private AC could also be a challenge for dynamic host
name. "*. domain" can also be forbidden by some enterprise security policy
Path style is useful in many cases. In ideal world I agree it should stay
deprecated...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
