dennishuo opened a new pull request, #432:
URL: https://github.com/apache/polaris/pull/432

   # Description
   
   Fields like externalId, userArn for AWS, tenantId for Azure, 
gcsServiceAccount were getting clobbered when parsing a JSON response due to 
the autogenerated model classes not correctly pulling in subtype properties 
from the API spec.
   
   This caused types with "required" subfields like Azure's tenantId to 
completely fail parsing when trying to get or update a catalog.
   
   Less noticeable but also bad was that these subtype properties were 
effectively invisible.
   
   Fixes # (issue)
   
   ## Type of change
   
   Please delete options that are not relevant.
   
   - [ ] Bug fix (non-breaking change which fixes an issue)
   
   # How Has This Been Tested?
   
   Please describe the tests that you ran to verify your changes. Provide 
instructions so we can reproduce. Please also list any relevant details for 
your test configuration
   
   - [ ] t_cli/src/test_cli.py
   
   
   # Checklist:
   
   Please delete options that are not relevant.
   
   - [ ] I have performed a self-review of my code
   - [ ] I have commented my code, particularly in hard-to-understand areas
   - [ ] I have made corresponding changes to the documentation
   - [ ] My changes generate no new warnings
   - [ ] If adding new functionality, I have discussed my implementation with 
the community using the linked GitHub issue
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to