andrew4699 commented on code in PR #458:
URL: https://github.com/apache/polaris/pull/458#discussion_r1849018695
##########
polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -1254,6 +1255,9 @@ public void doRefresh() {
public void doCommit(TableMetadata base, TableMetadata metadata) {
LOGGER.debug(
"doCommit for table {} with base {}, metadata {}", tableIdentifier,
base, metadata);
+ LOGGER.info(
+ "doCommit full new metadata: {}",
+ PolarisObjectMapperUtil.serialize(getCurrentPolarisContext(),
metadata));
Review Comment:
Yea I'm both worried about the performance hit of serializing such a large
object and the amount of data logged. Some possible options:
- Move to DEBUG (still performs serialization, does nothing for people who
run in INFO+ which should be common)
- Gate the entire thing behind a featureConfiguration
- Set a limit on the log output length in featureConfiguration (still
performs serialization)
What are your thoughts? I'm leaning toward the 2nd one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
