collado-mike commented on code in PR #422:
URL: https://github.com/apache/polaris/pull/422#discussion_r1854654088
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java:
##########
@@ -113,7 +115,8 @@ public PolarisEclipseLinkMetaStoreSessionImpl(
@NotNull PolarisStorageIntegrationProvider storageIntegrationProvider,
@NotNull RealmContext realmContext,
@Nullable String confFile,
- @Nullable String persistenceUnitName) {
+ @Nullable String persistenceUnitName,
+ PrincipalSecretsGenerator secretsGenerator) {
Review Comment:
`@NotNull` annotation, since we don't do any null checking below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
