collado-mike commented on code in PR #465:
URL: https://github.com/apache/polaris/pull/465#discussion_r1854799666
##########
polaris-service/src/main/java/org/apache/polaris/service/PolarisApplication.java:
##########
@@ -226,7 +230,17 @@ public void run(PolarisApplicationConfig configuration,
Environment environment)
new PolarisCallContextCatalogFactory(
entityManagerFactory, metaStoreManagerFactory, taskExecutor,
fileIOFactory);
- PolarisAuthorizer authorizer = new
PolarisAuthorizerImpl(configurationStore);
+ ConcurrentHashMap<RealmContext, EntityCache> realmEntityCache = new
ConcurrentHashMap<>();
Review Comment:
The `RealmEntityManagerFactory` already stores the cache in a map that's
never cleaned up. I'm hoping to address this with the `@RealmScoped` annotation
in the HK2 branch - we could consolidate all the realm-specific caches in a
single location with its own read/write-based TTL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
