collado-mike commented on code in PR #400:
URL: https://github.com/apache/polaris/pull/400#discussion_r1858972213
##########
polaris-service/src/main/java/org/apache/polaris/service/PolarisApplication.java:
##########
@@ -207,11 +208,15 @@ public void run(PolarisApplicationConfig configuration,
Environment environment)
csAware.setConfigurationStore(configurationStore);
}
+ Boolean skipCredentialSubscopingIndirection =
+ configurationStore.getConfiguration(
+ null,
PolarisConfiguration.SKIP_CREDENTIAL_SUBSCOPING_INDIRECTION.key);
TaskHandlerConfiguration taskConfig = configuration.getTaskHandler();
TaskExecutorImpl taskExecutor =
new TaskExecutorImpl(taskConfig.executorService(),
metaStoreManagerFactory);
TaskFileIOSupplier fileIOSupplier =
- new TaskFileIOSupplier(metaStoreManagerFactory, fileIOFactory);
+ new TaskFileIOSupplier(
+ metaStoreManagerFactory, fileIOFactory,
skipCredentialSubscopingIndirection);
Review Comment:
I'd probably just pass the `PolarisConfigurationStore` directly to the
`TaskFileIOSupplier` so that it can look up its own configuration keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
