adutra commented on code in PR #455:
URL: https://github.com/apache/polaris/pull/455#discussion_r1862435948
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java:
##########
@@ -49,23 +49,30 @@ public class AwsStorageConfigurationInfo extends
PolarisStorageConfigurationInfo
@JsonProperty(value = "userARN")
private @Nullable String userARN = null;
+ /** User ARN for the service principal */
+ @JsonProperty(value = "region")
+ private @Nullable String region = null;
+
@JsonCreator
public AwsStorageConfigurationInfo(
@JsonProperty(value = "storageType", required = true) @NotNull
StorageType storageType,
@JsonProperty(value = "allowedLocations", required = true) @NotNull
List<String> allowedLocations,
- @JsonProperty(value = "roleARN", required = true) @NotNull String
roleARN) {
- this(storageType, allowedLocations, roleARN, null);
+ @JsonProperty(value = "roleARN", required = true) @NotNull String
roleARN,
+ @JsonProperty(value = "region", required = false) @NotNull String
region) {
Review Comment:
Why `@NotNull` here while the property is nullable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
