dimas-b commented on code in PR #499:
URL: https://github.com/apache/polaris/pull/499#discussion_r1866007210
##########
polaris-service/src/main/java/org/apache/polaris/service/catalog/PolarisCatalogHandlerWrapper.java:
##########
@@ -301,27 +288,22 @@ private void authorizeBasicTableLikeOperationOrThrow(
// The underlying Catalog is also allowed to fetch "fresh" versions of the
target entity.
resolutionManifest.addPassthroughPath(
+ PRIMARY,
new ResolverPath(
PolarisCatalogHelpers.tableIdentifierToList(identifier),
PolarisEntityType.TABLE_LIKE,
true /* optional */),
- identifier);
+ identifier,
+ subType,
+ () -> {
+ if (subType == PolarisEntitySubType.TABLE) {
+ throw new NoSuchTableException("Table does not exist: %s",
identifier);
+ } else {
+ throw new NoSuchViewException("View does not exist: %s",
identifier);
+ }
Review Comment:
this was a pure copy-paste of old code :) I did not try to rework it for the
sake of correctness (aside from the secret rotation auth, which I had to change)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
