snazy commented on code in PR #522:
URL: https://github.com/apache/polaris/pull/522#discussion_r1878358470
##########
polaris-service/src/main/java/org/apache/polaris/service/BootstrapRealmsCommand.java:
##########
@@ -49,22 +48,24 @@ protected void run(
MetaStoreManagerFactory metaStoreManagerFactory =
configuration.findService(MetaStoreManagerFactory.class);
- PolarisConfigurationStore configurationStore =
- configuration.findService(PolarisConfigurationStore.class);
-
// Execute the bootstrap
Map<String, PrincipalSecretsResult> results =
metaStoreManagerFactory.bootstrapRealms(configuration.getDefaultRealms());
// Log any errors:
boolean success = true;
for (Map.Entry<String, PrincipalSecretsResult> result :
results.entrySet()) {
+ var realmId = result.getKey();
+ var secretsResult = result.getValue();
if (!result.getValue().isSuccess()) {
LOGGER.error(
- "Bootstrapping `{}` failed: {}",
- result.getKey(),
- result.getValue().getReturnStatus().toString());
+ "Bootstrapping `{}` failed: {}", realmId,
secretsResult.getReturnStatus().toString());
success = false;
+ } else {
+ var principalSecrets = secretsResult.getPrincipalSecrets();
+ System.out.printf(
+ "Bootstrap realm '%s' - root principal credentials: %s secret: %s",
Review Comment:
Yes. I thought, you could get random secrets.
The whole bootstrap scenario is too complex overall. The In-mem thing
bootstraps everything and logs - the EL thing does not log, but can generate
creds (which you cannot get)... And quite some `if` special cases that make it
complex to reason about the bootstrap process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
