eric-maynard commented on PR #490: URL: https://github.com/apache/polaris/pull/490#issuecomment-2532690655
@snazy > But how the cache is used is heavily influenced by the CDI work. Can you clarify this point? To me, this seems like a strict improvement over the current behavior. > Also, having a weigher meant to limit heap pressure but having it's calculation being largely off is IMO not good. Is the current behavior better? > It's also that the design has hard limits, meaning the cache cannot be as effective as it could be This is true today. I'm not intending to change this behavior in this PR, only to make a best-effort attempt to limit how large the cache will grow (in bytes). If you feel that making the cache size configurable is imperative I would be happy to review a PR to that effect or to piggyback that functionality here if you prefer. > and at the same time there can be an unbounded number of EntityCache instances. Today, this is not the case. The number of instances is bounded. > there's been no Polaris "GA" release yet, so there's no pressure to push things in. I don't fully understand this point. Can you clarify? I am eager to see our first release, but I don't think its delay means we should put off impactful work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
