jbonofre commented on code in PR #527:
URL: https://github.com/apache/polaris/pull/527#discussion_r1880143472
##########
dropwizard/service/src/main/java/org/apache/polaris/service/dropwizard/TimedApplicationEventListener.java:
##########
@@ -18,28 +18,28 @@
*/
package org.apache.polaris.service.dropwizard;
-import static
org.apache.polaris.core.monitor.PolarisMetricRegistry.TAG_RESP_CODE;
+import static
org.apache.polaris.service.dropwizard.monitor.PolarisMetricRegistry.TAG_RESP_CODE;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.Stopwatch;
+import io.micrometer.core.annotation.Timed;
import io.micrometer.core.instrument.Tag;
import jakarta.inject.Inject;
import jakarta.ws.rs.ext.Provider;
import java.lang.reflect.Method;
import java.util.List;
import java.util.concurrent.TimeUnit;
import org.apache.polaris.core.context.CallContext;
-import org.apache.polaris.core.monitor.PolarisMetricRegistry;
-import org.apache.polaris.core.resource.TimedApi;
+import org.apache.polaris.service.dropwizard.monitor.PolarisMetricRegistry;
import org.glassfish.jersey.server.monitoring.ApplicationEvent;
import org.glassfish.jersey.server.monitoring.ApplicationEventListener;
import org.glassfish.jersey.server.monitoring.RequestEvent;
import org.glassfish.jersey.server.monitoring.RequestEventListener;
/**
* An ApplicationEventListener that supports timing and error counting of
Jersey resource methods
- * annotated by {@link TimedApi}. It uses the {@link PolarisMetricRegistry}
for metric collection
- * and properly times the resource on success and increments the error counter
on failure.
+ * annotated by {@link Timed}. It uses the {@link PolarisMetricRegistry} for
metric collection and
+ * properly times the resource on success and increments the error counter on
failure.
*/
@Provider
public class TimedApplicationEventListener implements ApplicationEventListener
{
Review Comment:
I guess we can "refactore" the listener later (moving to Quarkus).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
