flyrain commented on code in PR #576:
URL: https://github.com/apache/polaris/pull/576#discussion_r1893328671
##########
dropwizard/service/src/test/java/org/apache/polaris/service/dropwizard/task/ManifestFileCleanupTaskHandlerTest.java:
##########
@@ -441,15 +442,18 @@ public void deleteFile(String location) {
.setName(UUID.randomUUID().toString())
.build();
- CompletableFuture<Void> future =
- CompletableFuture.runAsync(
- () -> {
- assertThatPredicate(handler::canHandleTask).accepts(task);
- handler.handleTask(task); // this will schedule the batch
deletion
- });
-
- // Wait for all async tasks to finish
- future.join();
+ try (ExecutorService executor = Executors.newSingleThreadExecutor()) {
+ CompletableFuture<Void> future;
+ future =
Review Comment:
minor suggestion: merge these two line together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
