Gerrit-K commented on code in PR #389:
URL: https://github.com/apache/polaris/pull/389#discussion_r1895896396
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java:
##########
@@ -141,6 +143,25 @@ private StorageConfigInfo getStorageInfo(Map<String,
String> internalProperties)
.setRegion(awsConfig.getRegion())
.build();
}
+ if (configInfo instanceof S3CompatibleStorageConfigurationInfo) {
+ S3CompatibleStorageConfigurationInfo s3Config =
+ (S3CompatibleStorageConfigurationInfo) configInfo;
+ return S3CompatibleStorageConfigInfo.builder()
+ .setStorageType(StorageConfigInfo.StorageTypeEnum.S3_COMPATIBLE)
+ .setS3Endpoint(s3Config.getS3Endpoint())
+ .setS3PathStyleAccess(s3Config.getS3PathStyleAccess())
+ .setSkipCredentialSubscopingIndirection(
+ s3Config.getSkipCredentialSubscopingIndirection())
+ .setAllowedLocations(s3Config.getAllowedLocations())
+
.setS3CredentialsCatalogAccessKeyId(s3Config.getS3CredentialsCatalogAccessKeyId())
+ .setS3CredentialsCatalogSecretAccessKey(
+ s3Config.getS3CredentialsCatalogSecretAccessKey())
+
.setS3CredentialsClientAccessKeyId(s3Config.getS3CredentialsClientSecretAccessKey())
+
.setS3CredentialsClientSecretAccessKey(s3Config.getS3CredentialsClientAccessKeyId())
Review Comment:
```suggestion
.setS3CredentialsClientAccessKeyId(s3Config.getS3CredentialsClientAccessKeyId())
.setS3CredentialsClientSecretAccessKey(s3Config.getS3CredentialsClientSecretAccessKey())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
