dimas-b commented on PR #590: URL: https://github.com/apache/polaris/pull/590#issuecomment-2566552894
`FileIOIntegrationTest` is not really a blackbox test. It tweaks the internals of CDI in DW. I'm not even sure why it needs a `DropwizardAppExtension`. I think it can be converted to a proper unit test. `RateLimiterFilterTest` could indeed be converted to a blackbox test. I did not do this initially because I thought that the test would become non-deterministic in the presence of other tests if the server is shared. Do you think it would be valuable as a blackbox test? `TimedApplicationEventListenerTest` makes assertions that assume exclusive access to the server, so I'm not sure it would be valuable as a blackbox text when the server is shared. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
