adutra commented on code in PR #601:
URL: https://github.com/apache/polaris/pull/601#discussion_r1900901060
##########
helm/polaris/templates/job.yaml:
##########
@@ -77,6 +77,10 @@ spec:
imagePullPolicy: {{ tpl .Values.image.pullPolicy . }}
command: ["/app/bin/polaris-service"]
args: ["bootstrap", "/app/config/polaris-server.yml"]
+ {{- if .Values.extraEnv }}
+ env:
+ {{- tpl (toYaml .Values.extraEnv) . | nindent 12 }}
Review Comment:
Should we use a separate field for this, e.g. `.Values.bootstrapExtraEnv`? I
fear that we are going to pass a ton of unnecessary envs to the job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
