dimas-b commented on code in PR #590:
URL: https://github.com/apache/polaris/pull/590#discussion_r1907974711
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisApplicationIntegrationTest.java:
##########
@@ -715,36 +622,22 @@ public void testRequestBodyTooLarge() {
// The size is set to be higher than the limit in
polaris-server-integrationtest.yml
Entity<PrincipalRole> largeRequest = Entity.json(new
PrincipalRole("r".repeat(1000001)));
- try (Response response =
- EXT.client()
- .target(
- String.format(
- "http://localhost:%d/api/management/v1/principal-roles";,
EXT.getLocalPort()))
- .request("application/json")
- .header("Authorization", "Bearer " + userToken)
- .header(REALM_PROPERTY_KEY, realm)
- .post(largeRequest)) {
+ try (Response response =
managementApi.request("v1/principal-roles").post(largeRequest)) {
Review Comment:
Thanks for pointing this out! I opened #630 to deal with this concern. Maybe
it's controversial, but let's see what people comment on that particular issue.
I'll refactor the body size test (will not remove that one).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
