eric-maynard commented on code in PR #631:
URL: https://github.com/apache/polaris/pull/631#discussion_r1909336898


##########
dropwizard/service/src/test/java/org/apache/polaris/service/dropwizard/PolarisApplicationIntegrationTest.java:
##########
@@ -712,7 +710,10 @@ public void testRequestHeaderTooLarge() {
 
   @Test
   public void testRequestBodyTooLarge() {
-    // The size is set to be higher than the limit in 
polaris-server-integrationtest.yml
+    // The behaviour in case of large requests depends on the specific server 
configuration.
+    // This test assumes that the server under test is configured to deny 
requests larger than
+    // 1000000 bytes. The test payload below assumes UTF8 encoding of ASCII 
charts plus a bit of

Review Comment:
   We don't need to do this here, but I wonder if we could somehow add a check 
for the limit to this test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to