dimas-b commented on code in PR #590: URL: https://github.com/apache/polaris/pull/590#discussion_r1909621817
########## integration-tests/src/main/java/org/apache/polaris/service/it/env/PolarisApiClient.java: ########## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.it.env; + +import static java.util.concurrent.TimeUnit.MINUTES; + +import com.fasterxml.jackson.annotation.JsonAutoDetect; +import com.fasterxml.jackson.annotation.PropertyAccessor; +import com.fasterxml.jackson.databind.DeserializationFeature; +import com.fasterxml.jackson.databind.ObjectMapper; +import com.fasterxml.jackson.databind.PropertyNamingStrategies; +import jakarta.ws.rs.client.Client; +import jakarta.ws.rs.client.ClientBuilder; +import jakarta.ws.rs.ext.ContextResolver; +import java.io.Serializable; +import java.net.URI; +import org.apache.iceberg.rest.RESTSerializers; +import org.apache.polaris.core.admin.model.PrincipalWithCredentials; + +public final class PolarisApiClient implements Serializable, AutoCloseable { Review Comment: Let's be practical about this. Not all that can be done, should be done :) Consider a real 3rd-party client that needs to talk to the Polaris Server. Obviously, the client cannot be expected to do just about anything that some other clients can do in principle. For example, the Iceberg REST Client is quite conservative in what it allows to customize. These blackbox tests actually define how Polaris is accessed in principle and what is possible to tune from the client side. Would it be sufficient to be able to inject custom headers (specific to the test environment) in addition to the Polaris base URI (which is already customizable)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
