flyrain commented on code in PR #469:
URL: https://github.com/apache/polaris/pull/469#discussion_r1914005921


##########
service/common/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java:
##########
@@ -107,12 +114,7 @@ private PolarisAdminService newAdminService(
     PolarisMetaStoreManager metaStoreManager =
         metaStoreManagerFactory.getOrCreateMetaStoreManager(realmContext);
     return new PolarisAdminService(
-        // FIXME remove call to CallContext.getCurrentContext()
-        CallContext.getCurrentContext(),
-        entityManager,
-        metaStoreManager,
-        securityContext,
-        polarisAuthorizer);
+        callContext, entityManager, metaStoreManager, securityContext, 
polarisAuthorizer);

Review Comment:
   I suggest postponing this change until we've fixed the line 101. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to