snazy commented on code in PR #741: URL: https://github.com/apache/polaris/pull/741#discussion_r1914836108
########## quarkus/service/src/main/java/org/apache/polaris/service/quarkus/metrics/QuarkusValueExpressionResolver.java: ########## @@ -22,16 +22,16 @@ import io.micrometer.common.lang.Nullable; import jakarta.annotation.Nonnull; import jakarta.enterprise.context.ApplicationScoped; -import org.apache.polaris.core.context.RealmContext; +import org.apache.polaris.core.context.RealmId; @ApplicationScoped public class QuarkusValueExpressionResolver implements ValueExpressionResolver { @Override public String resolve(@Nonnull String expression, @Nullable Object parameter) { // TODO maybe replace with CEL of some expression engine and make this more generic - if (parameter instanceof RealmContext realmContext && expression.equals("realmIdentifier")) { - return realmContext.getRealmIdentifier(); + if (parameter instanceof RealmId realmId && expression.equals("realmIdentifier")) { Review Comment: meh - does not work :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org