dimas-b commented on code in PR #748:
URL: https://github.com/apache/polaris/pull/748#discussion_r1915647533
##########
quarkus/admin/build.gradle.kts:
##########
@@ -84,3 +85,17 @@ tasks.named("sourcesJar") {
dependsOn("compileQuarkusGeneratedSourcesJava") }
tasks.named("javadoc") { dependsOn("jandex") }
tasks.named("quarkusDependenciesBuild") { dependsOn("jandex") }
+
+tasks.named("distZip") { dependsOn("quarkusBuild") }
+
+tasks.named("distTar") { dependsOn("quarkusBuild") }
+
+distributions {
+ main {
+ contents {
+ from("../../NOTICE")
+ from("../../LICENSE-BINARY-DIST").rename("LICENSE-BINARY-DIST",
"LICENSE")
Review Comment:
`LICENSE-BINARY-DIST` includes more than the admin tool uses by itself...
but I guess that's ok since it is part of the Polaris project as a whole.
##########
quarkus/admin/build.gradle.kts:
##########
@@ -84,3 +85,17 @@ tasks.named("sourcesJar") {
dependsOn("compileQuarkusGeneratedSourcesJava") }
tasks.named("javadoc") { dependsOn("jandex") }
tasks.named("quarkusDependenciesBuild") { dependsOn("jandex") }
+
+tasks.named("distZip") { dependsOn("quarkusBuild") }
+
+tasks.named("distTar") { dependsOn("quarkusBuild") }
+
+distributions {
+ main {
+ contents {
+ from("../../NOTICE")
+ from("../../LICENSE-BINARY-DIST").rename("LICENSE-BINARY-DIST",
"LICENSE")
+ from(project.layout.buildDirectory) {
include("polaris-quarkus-admin-*-runner.jar") }
Review Comment:
nit: would it make sense to include shell start scripts (similar to Spark,
for example)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
