snazy commented on code in PR #764:
URL: https://github.com/apache/polaris/pull/764#discussion_r1916312319
##########
LICENSE:
##########
@@ -200,9 +200,14 @@
See the License for the specific language governing permissions and
limitations under the License.
- This product bundles various third-party components also under the
- Apache Software License 2.0.
+--------------------------------------------------------------------------------
- Gradle (https://github.com/gradle/gradle)
- ./gradlew
- ./gradle/wrapper/gradle-wrapper.properties
\ No newline at end of file
+This product includes a gradle wrapper.
+
+* gradlew and gradle/wrapper/gradle-wrapper.properties
Review Comment:
Technically I'm not sure whether `gradle-wrapper.properties` actually
counts. It's _generated_ by Gradle code, but modified by us.
OTOH, it probably doesn't hurt?
##########
LICENSE:
##########
@@ -200,9 +200,14 @@
See the License for the specific language governing permissions and
limitations under the License.
- This product bundles various third-party components also under the
- Apache Software License 2.0.
+--------------------------------------------------------------------------------
Review Comment:
Looks very (overly?) verbose to me - beside a ton of `-` characters, the
information is still the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
