collado-mike commented on code in PR #724:
URL: https://github.com/apache/polaris/pull/724#discussion_r1919355183
##########
service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -1627,6 +1627,12 @@ private FileIO refreshIOWithCredentials(
// the credentials should always override table-level properties, since
// storage configuration will be found at whatever entity defines it
tableProperties.putAll(credentialsMap);
+
+ // Populate the internal properties to FileIO in case the FileIO
implementation needs them
+ Map<String, String> internalProperties =
+
storageInfoEntity.map(PolarisEntity::getInternalPropertiesAsMap).orElse(Map.of());
Review Comment:
Rather than a new `PolarisCatalogConfig` type, can we reuse the
`PolarisStorageConfigurationInfo`? Seems like that's an existing type that
should probably contain all of the information needed to configure the FileIO,
with the obvious exception of credentials. Adding custom properties to that
type actually makes a lot of sense so that users can configure connection
details when they create it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
