MonkeyCanCode commented on PR #726:
URL: https://github.com/apache/polaris/pull/726#issuecomment-2597578834

   > Ah! Nice and simple :) The `requirements.txt` approach should work.
   > 
   > Should poetry used in `/polaris` and 
`/getting-started/spark/notebooks/Dockerfile` be bumped as well? For the 
former, there's also #756, if that helps. For the latter I don't mind that 
much, because it's rather a demo that doesn't have any CI coverage, so bumping 
things there could break it.
   
   that is fair point. Yeah, I saw #756 and is thinking about to take it. I was 
waiting for those Quarkus fixes to be merge then start doing more validations 
and check-in more code. I seems to have a working setup from couple PR from 
@adutra that are not yet merged. So yeah, no longer a blocker for me to take 
more tasks. Again, thanks for the quick review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to