dimas-b commented on code in PR #724:
URL: https://github.com/apache/polaris/pull/724#discussion_r1922783430
##########
service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -1627,6 +1627,12 @@ private FileIO refreshIOWithCredentials(
// the credentials should always override table-level properties, since
// storage configuration will be found at whatever entity defines it
tableProperties.putAll(credentialsMap);
+
+ // Populate the internal properties to FileIO in case the FileIO
implementation needs them
+ Map<String, String> internalProperties =
+
storageInfoEntity.map(PolarisEntity::getInternalPropertiesAsMap).orElse(Map.of());
Review Comment:
> For OSS users, the logic of refreshIOWithCredentials is moved to
DefaultFileIOFactory. If users do not customize the FileIO, they can upgrade
directly without issues.
I did not see that in this PR... Did you push that change?
If possible, please add a new commit with that change so that we could talk
with concrete changes in mind :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
