dimas-b commented on code in PR #724:
URL: https://github.com/apache/polaris/pull/724#discussion_r1924533290
##########
service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOFactory.java:
##########
@@ -19,9 +19,21 @@
package org.apache.polaris.service.catalog.io;
import java.util.Map;
+import java.util.Set;
+import org.apache.iceberg.catalog.TableIdentifier;
import org.apache.iceberg.io.FileIO;
+import org.apache.polaris.core.persistence.PolarisResolvedPathWrapper;
+import org.apache.polaris.core.storage.PolarisStorageActions;
/** Interface for providing a way to construct FileIO objects, such as for
reading/writing S3. */
public interface FileIOFactory {
FileIO loadFileIO(String impl, Map<String, String> properties);
Review Comment:
I'd keep using this PR. Since there were no other reviews so far, I think it
should be ok to squash existing commits, rebase and force push. Then the PR
will be as new :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
