dimas-b commented on code in PR #859: URL: https://github.com/apache/polaris/pull/859#discussion_r1927544949
########## docker/elipselink/README.md: ########## @@ -0,0 +1,51 @@ +# Polaris with EclipseLink, Postgres and Spark SQL + +1. If such an image is not already present, build the Polaris image with support for EclipseLink and + the Postgres JDBC driver: + + ```shell + ./gradlew clean :polaris-quarkus-server:assemble :polaris-quarkus-admin:assemble \ + -PeclipseLinkDeps=org.postgresql:postgresql:42.7.4 \ + -Dquarkus.container-image.build=true Review Comment: nit: would it make sense to override the image name/tag to indicate it's with PostgreSQL? ########## docker/elipselink/README.md: ########## @@ -0,0 +1,51 @@ +# Polaris with EclipseLink, Postgres and Spark SQL + +1. If such an image is not already present, build the Polaris image with support for EclipseLink and + the Postgres JDBC driver: + + ```shell + ./gradlew clean :polaris-quarkus-server:assemble :polaris-quarkus-admin:assemble \ + -PeclipseLinkDeps=org.postgresql:postgresql:42.7.4 \ + -Dquarkus.container-image.build=true + ``` + +2. Start the docker compose group using either podman or docker: + + ```shell + podman compose -f docker/eclipselink/docker-compose.yml up + docker compose -f docker/eclipselink/docker-compose.yml up Review Comment: nit: making separate blocks of text makes copy-paste into shell easier -- GH renders the copy widget, but it copies the whole block of text :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
