snazy commented on code in PR #461:
URL: https://github.com/apache/polaris/pull/461#discussion_r1931065961
##########
quarkus/admin/src/test/java/org/apache/polaris/admintool/BootstrapCommandTest.java:
##########
@@ -32,16 +34,35 @@ class BootstrapCommandTest {
@Launch(
value = {
"bootstrap",
- "-r",
- "realm1",
- "-r",
- "realm2",
"-c",
- "realm1,root,s3cr3t",
- "-c",
- "realm2,root,s3cr3t"
+
"[{\"realm\":\"realm1\",\"principal\":\"root\",\"clientId\":\"root\",\"clientSecret\":\"s3cr3t\"}]"
})
public void testBootstrap(LaunchResult result) {
assertThat(result.getOutput()).contains("Bootstrap completed
successfully.");
}
+
+ @Test
+ @Launch(
+ value = {
+ "bootstrap",
+ "-c",
+
"[{\"realm\":\"realm1\",\"principal\":\"root\",\"clientId\":\"root\",\"clientSecret\":\"s3cr3t\"}]",
Review Comment:
I don't think users will get the JSON syntax on the command line right in
every circumstance. The previous approach at least allowed to use quotes around
arguments, if even necessary, w/o the need to think about the JSON syntax.
Automated tooling would have to deal with escaping of special characters.
`"` and `\` and `*` are possible in secrets - but escaping those for JSON
and then for the the command line is quite tricky to get right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
