eric-maynard commented on code in PR #889:
URL: https://github.com/apache/polaris/pull/889#discussion_r1931140759
##########
service/common/src/main/java/org/apache/polaris/service/persistence/InMemoryPolarisMetaStoreManagerFactory.java:
##########
@@ -95,25 +95,25 @@ public synchronized PolarisMetaStoreManager
getOrCreateMetaStoreManager(RealmId
public synchronized Supplier<PolarisMetaStoreSession>
getOrCreateSessionSupplier(
RealmId realmId) {
if (!bootstrappedRealms.contains(realmId.id())) {
- bootstrapRealmsAndPrintCredentials(List.of(realmId.id()));
+ bootstrapRealmsAndPrintCredentials(List.of(realmId));
}
return super.getOrCreateSessionSupplier(realmId);
}
- private void bootstrapRealmsAndPrintCredentials(List<String> realms) {
+ private void bootstrapRealmsAndPrintCredentials(List<RealmId> realms) {
PolarisCredentialsBootstrap credentialsBootstrap =
PolarisCredentialsBootstrap.fromEnvironment();
- Map<String, PrincipalSecretsResult> results =
+ Map<RealmId, PrincipalSecretsResult> results =
this.bootstrapRealms(realms, credentialsBootstrap);
- bootstrappedRealms.addAll(realms);
- for (String realmId : realms) {
- PrincipalSecretsResult principalSecrets = results.get(realmId);
+ for (RealmId realm : results.keySet()) {
+ bootstrappedRealms.add(realm.id());
Review Comment:
Shouldn't this use `RealmId` not `String`, so we don't need to call `id()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
