MonkeyCanCode commented on code in PR #898:
URL: https://github.com/apache/polaris/pull/898#discussion_r1932195566


##########
regtests/client/python/pyproject.toml:
##########
@@ -17,75 +17,37 @@
 # under the License.
 #
 
-[tool.poetry]
+[project]
 name = "polaris"
 version = "1.0.0"
 description = "Apache Polaris Management Service"
-authors = ["Apache Software Foundation <d...@polaris.apache.org>"]
-license = "Apache License 2.0"
+authors = [
+    {name = "Apache Software Foundation", email = "d...@polaris.apache.org"}
+]
 readme = "README.md"
-repository = "https://github.com/apache/polaris/";
+requires-python = ">=3.9,<4.0"
+license = "Apache-2.0"
 keywords = ["Polaris", "Polaris Management Service"]
-include = ["polaris.management/py.typed"]
-package-mode = true
+dynamic = ["classifiers"]
+dependencies = [
+    "urllib3>=1.25.3,<2.0",
+    "python-dateutil>=2.8.2",
+    "pydantic>=2.0.0",
+    "typing-extensions>=4.7.1",
+    "boto3==1.36.6",
+]
 
-[tool.poetry.dependencies]
-python = "^3.8"
+[project.urls]
+homepage = "https://polaris.apache.org/";
+repository = "https://github.com/apache/polaris/";
 
-urllib3 = "^1.25.3"
-python-dateutil = ">=2.8.2"
-pydantic = ">=2"
-typing-extensions = ">=4.7.1"
-boto3 = "==1.36.6"
+[tool.poetry]
+requires-poetry = ">=2.0"
+packages = [{ include = "polaris" }]
 
-[tool.poetry.dev-dependencies]
+[tool.poetry.group.test.dependencies]
 pytest = ">=7.2.1"
-flake8 = ">=4.0.0"
-types-python-dateutil = ">=2.8.19.14"
-mypy = "1.14.1"
-
 
 [build-system]
-requires = ["setuptools"]
-build-backend = "setuptools.build_meta"
-
-[tool.pylint.'MESSAGES CONTROL']
-extension-pkg-whitelist = "pydantic"
-
-[tool.mypy]
-files = [
-    "polaris",
-    #"test",  # auto-generated tests
-    "tests", # hand-written tests
-]
-# TODO: enable "strict" once all these individual checks are passing
-# strict = true
-
-# List from: 
https://mypy.readthedocs.io/en/stable/existing_code.html#introduce-stricter-options
-warn_unused_configs = true
-warn_redundant_casts = true
-warn_unused_ignores = true
-
-## Getting these passing should be easy
-strict_equality = true
-strict_concatenate = true
-
-## Strongly recommend enabling this one as soon as you can
-check_untyped_defs = true
-
-## These shouldn't be too much additional work, but may be tricky to
-## get passing if you use a lot of untyped libraries
-disallow_subclassing_any = true
-disallow_untyped_decorators = true
-disallow_any_generics = true
-
-### These next few are various gradations of forcing use of type annotations
-#disallow_untyped_calls = true
-#disallow_incomplete_defs = true
-#disallow_untyped_defs = true
-#
-### This one isn't too hard to get passing, but return on investment is lower
-#no_implicit_reexport = true
-#
-### This one can be tricky to get passing if you use a lot of untyped libraries
-#warn_return_any = true

Review Comment:
   Those are related for mypy when using as the build system. In this PR, I am 
switching to the poetry core as a build system.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to