flyrain commented on code in PR #924: URL: https://github.com/apache/polaris/pull/924#discussion_r1938332865
########## quarkus/defaults/src/main/resources/application.properties: ########## @@ -65,7 +65,7 @@ quarkus.micrometer.enabled=true quarkus.micrometer.export.prometheus.enabled=true quarkus.otel.enabled=true Review Comment: I'm not familiar with Quarkus, but I doubt this is a build-time property. Build-time properties are set during the build and can’t be changed at runtime. If it’s configurable in application.properties, it’s likely a runtime property instead. Looked a bit more, it’s an actually build-time property per https://quarkus.io/guides/opentelemetry. This is confusing for users and developers. I think what we can do is to separate out or comment out these build-time properties. I don’t want users confused by setting them at the runtime and expecting they are working that way. We will need more discussion on how we provide a consistent way for Polaris users to configure the server. Let me bring it up to dev list later. cc @eric-maynard @collado-mike @dennishuo @MonkeyCanCode -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
