gh-yzou commented on code in PR #932: URL: https://github.com/apache/polaris/pull/932#discussion_r1943435211
########## quarkus/admin/src/testFixtures/resources/org/apache/polaris/admintool/init.sql: ########## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +CREATE DATABASE polaris_realm2; Review Comment: Is that only used for the BootstrapCommandTest.java, maybe we can append the test name in the database name like polaris_realm_testbooststrap to be clear that is used for the purpose of the test. And what was confusing to me is that why the count number is not staring from 1, but from 2, is 1 have been reserved? if there is particular reason, can we add some comment here ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
