flyrain commented on code in PR #945:
URL: https://github.com/apache/polaris/pull/945#discussion_r1943768989
##########
polaris-core/src/main/resources/schemas/policies/system/data-compaction/2025-02-03.json:
##########
@@ -0,0 +1,41 @@
+{
+ "license": "Licensed under the Apache License, Version 2.0
(http://www.apache.org/licenses/LICENSE-2.0)",
+ "$id":
"https://polaris.apache.org/schemas/policies/system/data-compaction/2025-02-03.json";,
+ "title": "Data Compaction Policy",
+ "description": "Inheritable Polaris policy schema for Iceberg table data
compaction.",
+ "type": "object",
+ "properties": {
+ "version": {
+ "type": "string",
+ "const": "2025-02-03",
+ "description": "Schema version."
+ },
+ "enable": {
+ "type": "boolean",
+ "description": "Enable or disable data compaction."
+ },
+ "target_file_size_bytes": {
+ "type": "number",
+ "description": "Target data file size in bytes."
+ },
+ "config": {
+ "type": "object",
+ "description": "A map containing custom configuration properties. Please
note that interoperability is not guaranteed.",
+ "additionalProperties": {}
+ }
+ },
+ "required": ["enable"],
+ "additionalProperties": false,
+ "examples": [
+ {
+ "version": "2025-02-03",
+ "enable": true,
+ "target_file_size_bytes": 134217728,
+ "config": {
+ "compaction_strategy": "bin-pack",
+ "max-concurrent-file-group-rewrites": 5,
Review Comment:
We could reserve certain names, but each reserved name would become part of
the spec, making it very hard to remove later. This would lead to prolonged
debate about which names to reserve. On the upside, these `reserved` keys
would ensure interoperability. I prefer to keep things simple first, adding
keys if they are proved truly necessary. I'm also open to any suggestion of
reserved keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
