flyrain commented on code in PR #956: URL: https://github.com/apache/polaris/pull/956#discussion_r1945919970
########## extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/EclipseLinkProductionReadinessChecks.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.extension.persistence.impl.eclipselink; + +import static org.eclipse.persistence.config.PersistenceUnitProperties.JDBC_URL; + +import io.quarkus.runtime.StartupEvent; +import jakarta.enterprise.context.ApplicationScoped; +import jakarta.enterprise.event.Observes; +import java.io.IOException; +import java.nio.file.Path; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +@ApplicationScoped +public class EclipseLinkProductionReadinessChecks { + + private static final Logger LOGGER = + LoggerFactory.getLogger(EclipseLinkProductionReadinessChecks.class); + + public void checkJdbcUrl( + @Observes StartupEvent event, EclipseLinkConfiguration eclipseLinkConfiguration) { + try { + var confFile = eclipseLinkConfiguration.configurationFile().map(Path::toString).orElse(null); + var persistenceUnitName = + confFile != null ? eclipseLinkConfiguration.persistenceUnit() : null; + var unit = + PolarisEclipseLinkPersistenceUnit.locatePersistenceUnit(confFile, persistenceUnitName); + var properties = unit.loadProperties(); + var jdbcUrl = properties.get(JDBC_URL); + if (jdbcUrl != null && jdbcUrl.startsWith("jdbc:h2")) { + LOGGER.warn( + "The current persistence unit is intended for tests only; do not use it in production " + + "(offending configuration option: 'polaris.persistence.eclipselink.configuration-file')"); Review Comment: It's good to have a warn like this. To make it more useful, I think we could point users to a page which says what a production-level configuration looks like. Also I guess we can make it more visible by adding a ASCII Graphs, or something like !!!! in the beginning. WDYT? ```suggestion "The current persistence unit(jdbc:h2) is intended for tests only; do not use it in production " + "(offending configuration option: 'polaris.persistence.eclipselink.configuration-file')"); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
