adutra commented on code in PR #921:
URL: https://github.com/apache/polaris/pull/921#discussion_r1946662666
##########
service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -1256,6 +1262,8 @@ public void doRefresh() {
@Override
public void doCommit(TableMetadata base, TableMetadata metadata) {
+ eventEmitter.fire(new BeforeTableCommitEvent(base, metadata));
Review Comment:
One potential problem with the Jakarta events approach is that the firing is
synchronous. This call can potentially take a long time to complete, depending
on how many observers are subscribed, and how long they take to process the
event.
There is a `fireAsync` method, I think it would be more appropriate.
But in general, maybe using a more robust event bus like the one provided by
Vert.x would be a better idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
