dennishuo commented on code in PR #988:
URL: https://github.com/apache/polaris/pull/988#discussion_r1952094067
##########
regtests/client/python/cli/command/catalogs.py:
##########
@@ -199,12 +194,33 @@ def execute(self, api: PolarisDefaultApi) -> None:
default_base_location=new_default_base_location,
additional_properties=new_additional_properties
)
- if (self._has_aws_storage_info() or self._has_azure_storage_info()
or self._has_gcs_storage_info() or
- self.allowed_locations or self.default_base_location):
+
+ if (self._has_aws_storage_info() or self._has_azure_storage_info()
or
+ self._has_gcs_storage_info() or self.allowed_locations):
Review Comment:
Yes, I suspect it was originally present here because on the backend,
changes to default_base_location do invoke the codepath for updating
storage_config_info just to make sure default_base_location is present in the
allowed_locations, but the client-side doesn't actually make any changes to
storage_config_info when default_base_location is changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
