adutra commented on code in PR #987:
URL: https://github.com/apache/polaris/pull/987#discussion_r1952914611
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationTest.java:
##########
@@ -157,6 +161,20 @@ static void setup(PolarisApiEndpoints apiEndpoints,
ClientCredentials credential
principalRoleName = client.newEntityName("rest-admin");
principalCredentials =
managementApi.createPrincipalWithRole(principalName, principalRoleName);
catalogApi = client.catalogApi(principalCredentials);
+ URI testRootUri =
+ Optional.ofNullable(System.getenv("INTEGRATION_TEST_TEMP_DIR"))
+ .map(URI::create)
+ .orElse(tempDir.toUri());
+ s3BucketBase =
+ Optional.ofNullable(System.getenv("INTEGRATION_TEST_S3_PATH"))
Review Comment:
Sure, let's consolidate then 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]