kameshsampath commented on issue #996:
URL: https://github.com/apache/polaris/issues/996#issuecomment-2664812401
I just went through the code to see where to patch,
Class 1: I did add case insensitive check in
`org.apache.polaris.service.admin.PolarisServiceImpl`
```java
private void validateStorageConfig(
StorageConfigInfo storageConfigInfo, RealmContext realmContext) {
List<String> allowedStorageTypes =
configurationStore.getConfiguration(
realmContext,
PolarisConfiguration.SUPPORTED_CATALOG_STORAGE_TYPES);
if
(allowedStorageTypes.stream().noneMatch(storageConfigInfo.getStorageType().name()::equalsIgnoreCase))
{
LOGGER
.atWarn()
.addKeyValue("storageConfig", storageConfigInfo)
.log("Disallowed storage type in catalog");
throw new IllegalArgumentException(
"Unsupported storage type: " + storageConfigInfo.getStorageType());
}
}
```
Class 2: StorageConfigInfo `spec/polaris-management-service.yml`
But then to make StorageConfigInfo enum always `upperCase` the `value` seem
not possbile to patch as the class is generated form the Spec unless there is
way to let the generator generate code to handle patching.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
