dimas-b commented on code in PR #1004:
URL: https://github.com/apache/polaris/pull/1004#discussion_r1964864986
##########
site/content/in-dev/unreleased/command-line-interface.md:
##########
@@ -159,7 +159,13 @@ polaris catalogs create \
--allowed-location s3://example-bucket/second_location \
--allowed-location s3://other-bucket/third_location \
--role-arn ${ROLE_ARN} \
- my_other_catalog
+ my_other_catalog
Review Comment:
nit: using separate code blocks ("```") might be preferable as these
commands are not related to each other.
##########
site/content/in-dev/unreleased/entities.md:
##########
@@ -36,6 +36,8 @@ All catalogs in Polaris are associated with a _storage type_.
Valid Storage Type
For details on how to use Storage Types in the REST API, see [the API
docs]({{% github-polaris "regtests/client/python/docs/StorageConfigInfo.md"
%}}).
+For usage examples of storage types, see [the CLI docs]({{% github-polaris
"docs/command-line-interface.md" %}}).
Review Comment:
Will this make a link from the Polaris Web side to the Polaris GH file?.. If
so, I do not think it's a good idea. I think this link should be from the
entities Web site page to the CLI Web site page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]