snazy commented on PR #969: URL: https://github.com/apache/polaris/pull/969#issuecomment-2674476085
> I believe we have reached a general consensus on policy management: > > 1. Design Document: The design document [1] was published over two months ago, triggering a lot of discussions. Stakeholders from various companies—including representatives from Dremio—actively contributed, and all feedback has been incorporated without any outstanding blockers. > > 2. Review Sessions: We conducted multiple review sessions with key stakeholders such as @jbonofre, @omarsmak, @RussellSpitzer and several others. Through these discussions, we aligned on the overall approach. > > 3. PR [Add data compaction policy schema #945](https://github.com/apache/polaris/pull/945) was received strong support, not only from committer @eric-maynard but also from @omarsmak, one of the stakeholders from Dremio and @HonahX, confirming broad agreement. > > > [1] https://docs.google.com/document/d/1Vuhw5b9-6KAol2vU3HUs9FJwcgWtiVVXMYhLtGmz53s/edit?tab=t.0 (Not sure how the linked google doc is related to this PR) The points I raised are about: 1. The changes committed to the production code base are not used, there is just no code that uses those - and won't be used soon. Those belong to a topic that's overall still WIP - hence I object merging it into `main` at this point. 2. These files land in a place that makes it extremely hard for arbitrary consumers to consume those. I do not think that those should live there. 3. #945 was merged without giving all contributors enough time to review. I propose to move the work to a feature branch and go from there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
