mansehajsingh commented on code in PR #1037:
URL: https://github.com/apache/polaris/pull/1037#discussion_r1974542834
##########
service/common/src/main/java/org/apache/polaris/service/catalog/PolarisCatalogHandlerWrapper.java:
##########
@@ -571,10 +573,17 @@ public ListTablesResponse listTables(Namespace namespace)
{
return doCatalogOperation(() -> CatalogHandlers.listTables(baseCatalog,
namespace));
}
- public LoadTableResponse createTableDirect(Namespace namespace,
CreateTableRequest request) {
+ /**
+ * Create a table.
+ * @param namespace the namespace to create the table in
+ * @param request the table creation request
+ * @return ETagged {@link LoadTableResponse} to uniquely identify the table
metadata
+ */
+ public ETaggedResponse<LoadTableResponse> createTableDirect(Namespace
namespace, CreateTableRequest request) {
Review Comment:
Iceberg response types have fluent builders that may evolve independently.
Introducing this wrapper around it allows us to keep using the defined builders
without having to write logic to keep parity to features introduced in new
iceberg versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
