travis-bowen commented on code in PR #1060:
URL: https://github.com/apache/polaris/pull/1060#discussion_r1974559007
##########
regtests/t_pyspark/src/conftest.py:
##########
@@ -39,15 +40,30 @@ def polaris_host():
def polaris_port():
return int(os.getenv('POLARIS_PORT', '8181'))
[email protected]
+def polaris_path_prefix():
+ """
+ Used to provide a path prefix between the port number and the standard
polaris endpoint paths
+ :return:
+ """
+ return os.getenv('POLARIS_PATH_PREFIX', '')
Review Comment:
Yeah - you're right - there's some inconsistencies.
Polaris_Host => no leading or trailing /
AWS_Bucket_Prefix = > No leading or trailing /
URL Schema => Updated to not have leading or trailing /
POLARIS_PATH_PREFIX => Now also updated to not have a leading or trailing /
(the callsites that use it can determine whether to add those)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
